Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UR] Consolidate platform and adapter backend enums into one. #17605

Open
wants to merge 3 commits into
base: sycl
Choose a base branch
from
Open

[UR] Consolidate platform and adapter backend enums into one. #17605

wants to merge 3 commits into from

Conversation

aarongreig
Copy link
Contributor

@aarongreig aarongreig commented Mar 24, 2025 •
edited
Loading

second attempt to land #16173

@aarongreig aarongreig requested review from a team as code owners March 24, 2025 13:53
steffenlarsen
steffenlarsen approved these changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It looks like a NFC to me, is that right?

@aarongreig
Copy link
Contributor Author

yeah I guess it kind of is, although as we've seen it does break other changes that use the affected enums

@aarongreig aarongreig requested review from a team as code owners April 4, 2025 13:11
@aarongreig
Copy link
Contributor Author

aarongreig commented Apr 4, 2025 •
edited
Loading

ping @intel/dpcpp-nativecpu-reviewers note this is not a new patch, it's an attempt to re-land with a minor fix

hvdijk
hvdijk approved these changes Apr 7, 2025
View reviewed changes
Copy link
Contributor

@hvdijk hvdijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NativeCPU changes are identical to the earlier attempt so still look fine, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvdijk hvdijk hvdijk approved these changes

@kbenzie kbenzie kbenzie approved these changes

@EwanC EwanC EwanC approved these changes

@martygrant martygrant martygrant approved these changes

@Seanst98 Seanst98 Seanst98 approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@frasercrmck frasercrmck Awaiting requested review from frasercrmck frasercrmck is a code owner automatically assigned from intel/llvm-reviewers-cuda

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aarongreig @hvdijk @kbenzie @EwanC @martygrant @Seanst98 @steffenlarsen